Fix NodeJS compatibilty across different versions #94
Conversation
piotr-roslaniec
force-pushed
the
node-lts
branch
from
2386bba
to
cf6cb47
Compare
piotr-roslaniec
force-pushed
the
node-lts
branch
from
da606e6
to
174c414
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 23.23% 23.42% +0.19%
==========================================
Files 18 18
Lines 3504 3475 -29
==========================================
Hits 814 814
+ Misses 2690 2661 -29 ☔ View full report in Codecov by Sentry. |
piotr-roslaniec
changed the title
piotr-roslaniec
requested review from
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@nucypher/nucypher-core", | |||
| "version": "0.14.1", | |||
| "version": "0.14.5", | |||
There was a problem hiding this comment.
As an aside: @KPrasch , nucypher is still using nucypher-core 0.13.0 - https://github.com/nucypher/nucypher/blob/v7.4.x/pyproject.toml#L9. Is it time to update that? From the nucypher-core changelog, there doesn't seem to be a compatibility problem for nodes.
There was a problem hiding this comment.
I don't think there are any breaking of functional issues. IIRC, the difference between 0.13.x and 0.14.x is only related to WASM bindings.
There was a problem hiding this comment.
Speaking of the changelog - it could be good to update it for versions 0.14.1 -> 0.14.5 even if it is to say "Fixed packaging issue".
Type of PR:
Required reviews:
What this does:
@nucypher/nucypher-corewould not work for Node.js 18+ users@nucypher/nucypher-core:0.14.5release. The version bump from0.14.1to0.14.5is the aftermath of previous try-and-fail attempts at building a correct package. Functionally, these versions (0.14.1-5) are the same. A0.14.5tag has been created.Notes for reviewers: