Adapt NuCypher to Umbral==0.1.3a0 #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPrasch
changed the title
michwill
approved these changes
Dec 17, 2018
tuxxy
previously requested changes
Dec 17, 2018
nucypher/config/keyring.py
Outdated
| @@ -62,7 +64,7 @@ | |||
| # Keyring | |||
| __WRAPPING_KEY_LENGTH = 32 | |||
| __WRAPPING_KEY_INFO = b'NuCypher-KeyWrap' | |||
| __HKDF_HASH_ALGORITHM = hashes.BLAKE2b | |||
| __HKDF_HASH_ALGORITHM = SHA256 | |||
There was a problem hiding this comment.
This doesn't actually need to be updated to SHA256 for compatibility.
There was a problem hiding this comment.
Suggested change
| __HKDF_HASH_ALGORITHM = SHA256 | |
| __HKDF_HASH_ALGORITHM = hashes.BLAKE2b |
cygnusv
approved these changes
Dec 17, 2018
nucypher/config/keyring.py
Outdated
| __HKDF_HASH_ALGORITHM = SHA256 | ||
| __HKDF_HASH_LENGTH = 64 | ||
| __HKDF_HASH_ALGORITHM = BLAKE2B | ||
| __HKDF_HASH_LENGTH = BLAKE2B_DIGEST_LENGTH |
There was a problem hiding this comment.
This is unused, and also it doesn't have much sense, since there's no such thing as the hash length in HKDF. This was in fact specific to BLAKE2b only. I think we can safely remove this line.
nucypher/config/keyring.py
Outdated
| @@ -43,9 +43,11 @@ | |||
|
|
|||
| from nucypher.config.constants import DEFAULT_CONFIG_ROOT | |||
| from nucypher.crypto.api import generate_self_signed_certificate | |||
| from nucypher.crypto.constants import SHA256, BLAKE2B, BLAKE2B_DIGEST_LENGTH | |||
KPrasch
force-pushed
the
adapt-signatures
branch
from
92af45a
to
e9e933c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a bunch of pinned Pipfile deps. Be sure to update to the latest pipenv!