Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for the whole PRE scenario and some internals #54

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jun 22, 2021

Fixes #9

  • added benchmarks for Capsule::from_public_key(), Capsule::open_original(), and Capsule::open_reencrypted()
  • internal benchmarks are only run with the feature bench-internals
  • added benchmarks for encrypt(), decrypt_original(), generate_kfrags(), reencrypt(), and open_reencrypted() (only for 2 out of 3 scenarios)
  • added benchmarking to Github actions (build only, running them is too slow)

@fjarri fjarri added enhancement New feature or request tests Test suite labels Jun 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #54 (844d376) into master (55af276) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   84.56%   83.94%   -0.63%     
==========================================
  Files          12       13       +1     
  Lines         946      953       +7     
==========================================
  Hits          800      800              
- Misses        146      153       +7     
Impacted Files Coverage Δ
umbral-pre/src/bench.rs 0.00% <0.00%> (ø)
umbral-pre/src/capsule.rs 89.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55af276...844d376. Read the comment docs.

@cygnusv
Copy link
Member

cygnusv commented Jul 7, 2021

Can we see the benchmark reports on CI? I can't find them

@fjarri
Copy link
Contributor Author

fjarri commented Jul 7, 2021

Not currently, the CI task added in the PR only builds the benchmarks, but does not run them.

Does it make sense to actually run them in CI? It's pretty slow, and in order to get some use out of it we need to at least check for performance regressions automatically - I wonder if it's possible.

@fjarri fjarri force-pushed the more-benchmarks branch 4 times, most recently from f277a94 to 844d376 Compare July 9, 2021 00:30
@fjarri fjarri force-pushed the more-benchmarks branch 2 times, most recently from 1c2084e to c7d9c0c Compare July 12, 2021 16:52
@fjarri fjarri merged commit 8275afc into nucypher:master Jul 12, 2021
@fjarri fjarri deleted the more-benchmarks branch July 12, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks
4 participants