fix(code-block): escape html chars to text content #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritx
reviewed
Jan 18, 2024
| export function renderCodeBlock({ name, code, attr }, fn) { | ||
| // console.info(name, code, attr, fn) | ||
| if (name) attr.class = concat(`syntax-${name}`, attr.class) | ||
| const body = join(code) | ||
| const body = join(code).replace(replaceSpecialChars, c => specialChars[c]) |
There was a problem hiding this comment.
should be replaceAll, here? otherwise, would only replace the first one.
There was a problem hiding this comment.
Looks like there is a 'g' flag on the RegExp which makes it global (replace all)
|
Looks solid. I might later apply this regexp only if there is no custom syntax highlighter provided on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #168
Escapes chars from code blocks to prevent them from being parsed as HTML.
This is not ideal, as code markup parsers have to then check for replaced char codes.
But replacing after running the
fnfunction is also not great, because it potentially appends real HTML parts (e.g.,<span>s) to do, for example, highlighting.