Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate dotnetcli #1355

Conversation

werwolfby
Copy link
Contributor

@werwolfby werwolfby commented Mar 25, 2024

fixes issue #1344

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

It was originally posted by @cwuethrich at #1345, but has some conflicts. I've cherry-pick his commit (author is preserved). And add a test with the issue that I could reproduce with coverlet.console. Which is not required to be installed, so test is inconclusive 😞.

@werwolfby werwolfby changed the title Feature/avoid duplicate dotnetcli Avoid duplicate dotnetcli Mar 25, 2024
@werwolfby
Copy link
Contributor Author

Thank you @cwuethrich for actual fix.

@werwolfby werwolfby force-pushed the feature/avoid-duplicate-dotnetcli branch from 8a1fe2e to 079cb9b Compare March 25, 2024 07:57
@matkoch matkoch added this to the v8.0.1 milestone Jun 12, 2024
@matkoch matkoch force-pushed the develop branch 2 times, most recently from 6d02194 to 4bfee84 Compare June 13, 2024 21:33
@matkoch matkoch modified the milestones: v8.1.0, v8.1.1 Jul 3, 2024
@matkoch matkoch force-pushed the develop branch 4 times, most recently from 85998da to 01b2b6e Compare July 9, 2024 00:20
@matkoch matkoch modified the milestones: v8.1.1, v8.1.0 Jul 11, 2024
@matkoch matkoch closed this Jul 11, 2024
@werwolfby
Copy link
Contributor Author

Any reason for it to be closed?

@matkoch
Copy link
Member

matkoch commented Jul 12, 2024

yes, because it's been fixed differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants