Added command line option to select audio output device. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as Midi port) Use -a:<audio_device_index> command line argument to specify audio output device..
nukeykt
reviewed
Apr 12, 2024
src/mcu.cpp
Outdated
| @@ -1064,12 +1064,16 @@ int MCU_OpenAudio(void) | |||
| spec.channels = 2; | |||
| spec.callback = audio_callback; | |||
| spec.samples = audio_page_size / 4; | |||
|
|
|||
| const char* audioDevicename = SDL_GetAudioDeviceName(deviceIndex, 0); | |||
There was a problem hiding this comment.
maybe add range check for deviceIndex? (against what SDL_GetNumAudioDevices() returns)
There was a problem hiding this comment.
OK, I have added error checking and fixed default device selection logic ( 0 does not mean default, but always denotes 1st device).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use -a:<audio_device_index> command line argument to specify audio output device.