Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context support for ticket field #110

Merged
merged 3 commits into from
May 13, 2019
Merged

Context support for ticket field #110

merged 3 commits into from
May 13, 2019

Conversation

nukosuke
Copy link
Owner

#70

@nukosuke nukosuke added this to the v0.3.0 milestone May 13, 2019
@nukosuke nukosuke self-assigned this May 13, 2019
@nukosuke nukosuke requested a review from tamccall May 13, 2019 08:58
tamccall
tamccall approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@tamccall tamccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to fix a typo in the pr title before you merge otherwise looks good to me.

@nukosuke nukosuke changed the title Context support for ticet field Context support for ticket field May 13, 2019
@nukosuke
Copy link
Owner Author

thanks. nice catch 👍

@nukosuke nukosuke merged commit d05042c into master May 13, 2019
@nukosuke nukosuke deleted the context-ticet-field branch May 13, 2019 12:41
fairyhunter13 added a commit to fairyhunter13/go-zendesk that referenced this pull request Jul 12, 2020
@fairyhunter13
Context support for ticket field (nukosuke#110)
fe82901 
* Fix test for context support of ticket field

* Add context support for ticket field

* Regenerate mock client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamccall tamccall tamccall approved these changes

Assignees

@nukosuke nukosuke

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nukosuke @tamccall