Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetWebhookSigningSecret #254

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add GetWebhookSigningSecret #254

merged 2 commits into from
Feb 7, 2023

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Feb 6, 2023

The result of GetWebhook doesn't contain the signing secret. This isn't a problem of this package, it's simply that Zendesk API doesn't return the signing secret field in the payload. In order to receive it it's necessary to call a separate endpoint.

@nukosuke
Copy link
Owner

nukosuke commented Feb 6, 2023

@enumag

Thank you for your contribution!

CI failed because the mock func for new GetWebhookSigningSecret is missing.
Could you re-generate zendesk/mock package?

go install github.com/golang/mock/mockgen@v1.6.0 # if you don't have mockgen
go generate ./... # at project root

@nukosuke nukosuke added this to the v0.14.x milestone Feb 6, 2023
@enumag
Copy link
Contributor Author

enumag commented Feb 6, 2023

@nukosuke Thanks for the instructions! Done.

Copy link
Owner

@nukosuke nukosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nukosuke nukosuke merged commit 74f90f9 into nukosuke:master Feb 7, 2023
@enumag
Copy link
Contributor Author

enumag commented Feb 7, 2023

Thanks! Can you tag it please? I'd like to use this endpoint.

@nukosuke
Copy link
Owner

nukosuke commented Feb 7, 2023

v0.14.0 has been released 🎉
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants