-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for brand create #62
Conversation
nukosuke
commented
Mar 11, 2019
•
edited
Loading
edited
- struct
- API interface
- Create implementation
- test
8e4feab
to
e43b344
Compare
Need to prepare brand fixture udpate 19.03.15: done 8eee782 |
@tamccall Would you review this? |
|
||
// CreateBrand creates new brand | ||
// https://developer.zendesk.com/rest_api/docs/support/brands#create-brand | ||
func (z *Client) CreateBrand(brand Brand) (Brand, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine but there are a lot of places in here where this receiver is not a pointer.
We might need to create an issue to update all of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I opened new issue about this #80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a small comment concerning our func receivers in this package generally, but this pr LGTM.
Add support for brand create