Add support for brand create #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nukosuke
commented
Mar 11, 2019
•
nukosuke
commented
- struct
- API interface
- Create implementation
- test
houndci-bot
reviewed
Mar 11, 2019
nukosuke
force-pushed
the
brand-create
branch
2 times, most recently
from
8e4feab
to
e43b344
Compare
Closed
|
Need to prepare brand fixture udpate 19.03.15: done 8eee782 |
|
@tamccall Would you review this? |
tamccall
reviewed
Mar 15, 2019
|
|
||
| // CreateBrand creates new brand | ||
| // https://developer.zendesk.com/rest_api/docs/support/brands#create-brand | ||
| func (z *Client) CreateBrand(brand Brand) (Brand, error) { |
There was a problem hiding this comment.
this is fine but there are a lot of places in here where this receiver is not a pointer.
We might need to create an issue to update all of those.
There was a problem hiding this comment.
Thanks. I opened new issue about this #80
tamccall
reviewed
Mar 15, 2019
tamccall
approved these changes
Mar 15, 2019
fairyhunter13
added a commit
to fairyhunter13/go-zendesk
that referenced
this pull request
Jul 12, 2020
Add support for brand create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.