Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async DataHandler #23

Closed
dbalduini opened this issue Aug 19, 2014 · 7 comments
Closed

Async DataHandler #23

dbalduini opened this issue Aug 19, 2014 · 7 comments

Comments

@dbalduini
Copy link
Contributor

Hello

I am using the play-2.2 branch and i could not found any implementation of the DataHandler that returns Futures.

I don't want to block my app so i will probably implement it my self. Should i send a pull request after i finish it?

Regards, Diego
@tsuyoshizawa
Copy link
Member

Can you merge the pull request from #18 commits?

It should be conflict and resolve.
Then I would merge the pull request to play-2.2 branch.

@dbalduini
Copy link
Contributor Author

Yes sure!

I will do that asap.

@dbalduini
Copy link
Contributor Author

I submitted the PR #25 to fix this.

tsuyoshizawa added a commit that referenced this issue Aug 23, 2014
@tsuyoshizawa
Merge pull request #25 from dbalduini/play-2.2.x
991bc87 
Fix: Async DataHandler #23
@tsuyoshizawa
Copy link
Member

Merged. Thanks!

@dbalduini
Copy link
Contributor Author

Thanks! Will you publish it to Nexus as version 0.7.4?

@tsuyoshizawa
Copy link
Member

Yes, I will.

If a master branch looks no problem, then I will publish version 0.9.0 together as async supporting.
So, please wait a little.

@tsuyoshizawa
Copy link
Member

I just published 0.7.4-SNAPSHOT version.
Just a quick note to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsuyoshizawa @dbalduini