Add akka-http-oauth2-provider sub project. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I'm not an akka-http user, so this PR would help for akka-http users.
I see. Let me know when you complete the work. |
| val oauth2DataHandler: DataHandler[U] | ||
|
|
||
| val tokenEndpoint = new TokenEndpoint { | ||
| override val handlers = Map( |
There was a problem hiding this comment.
All authentications are enabled by default, it is not good to keep security.
Developers will use authentication they do not use without being aware.
Could you change this like Play subproject?
…tokenEndpoint from akka-http-provider.
|
Hello. I removed the default tokenEndpoint as you suggested, and I added tests for the helper route. Is it ok for you? |
@cdiniz Yes. Thank you. Could you rename |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys. I have been working on lightbend templates (play+slick+oauth2,akka-http-slick-oauth2) using your great scala-oauth2-provider. Since you don't have any helper for akka http, I decided to do it. What do you think? I have a sample template using the same helper: https://github.com/cdiniz/slick-akka-http-oauth2.
P.S. I'll work on tests for the accessTokenRoute asap.