Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save width and height as S3 metadata on posters #3771

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Jan 12, 2024

Summary

Posters should save with width and height as S3 object metadata (same as regular pyramids).

Note: Adding metadata to existing posters is separate issue. #3811

Specific Changes in this PR

  • Adjust frame extractor lambda code to determine width and height of the poster from the video or playlist file. Then write width and height as user defined S3 object metadata x-amz-meta-width and x-amz-meta-height when saving the poster image.
  • Update README with instructions for how to use local lambda code rather than the shared dev environment lambdas.

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

Please let end users know what they need to do to test on staging or production

  • requires someone with access to pyramids bucket to test

Also please let developers know if there are any special instructions to test this in the development environment.

  • Use local frame extractor lambda code on this branch or deploy to dev envs (not sure of our process here)
  • Create a poster image for a video in the UI
  • Check the poster in S3 (it's in the pyramids bucket, in a posters directory with the pairtreed file set id as the filename).
  • Make sure the amz-meta-width and amz-meta-height keys are present and correctly populated in S3 object metadata

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks
    • (?) How do dev environment lambdas get updated? Can't recall....

Tested/Verified

  • End users/stakeholders

@kdid kdid merged commit fa956ad into deploy/staging Jan 16, 2024
4 checks passed
@kdid kdid deleted the 3751-posters-dimensions branch January 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants