fix(UI): pod selection fix (#1266)

Signed-off-by: Shakira M <shakira_m@intuit.com> Co-authored-by: Shakira M <shakira_m@intuit.com>
numaproj · Oct 25, 2023 · b86b225 · b86b225
1 parent 07a7b8e
commit b86b225
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/ui/src/components/pages/Pipeline/partials/Graph/partials/NodeInfo/partials/Pods/index.tsx b/ui/src/components/pages/Pipeline/partials/Graph/partials/NodeInfo/partials/Pods/index.tsx
diff --git a/...e/partials/Graph/partials/NodeInfo/partials/Pods/partials/SearchablePodsHeatMap/index.tsx b/...e/partials/Graph/partials/NodeInfo/partials/Pods/partials/SearchablePodsHeatMap/index.tsx
diff --git a/ui/src/types/declarations/pods.d.ts b/ui/src/types/declarations/pods.d.ts
@@ -37,7 +37,6 @@ export interface SearchablePodsHeatMapProps {
   podsDetailsMap: Map<string, PodDetail>;
   onPodClick: (e: Element | EventType, pod: Pod) => void;
   selectedPod: Pod | undefined;
-  setSelectedPod: Dispatch<SetStateAction<Pod>>;
 }
 
 export interface PodsHeatMapProps {

diff --git a/ui/src/utils/fetcherHooks/podsViewFetch.test.ts b/ui/src/utils/fetcherHooks/podsViewFetch.test.ts
@@ -64,6 +64,7 @@ describe("Custom Pods hook", () => {
           "default",
           "simple-pipeline",
           "cat",
+          undefined,
           jest.fn() as Dispatch<SetStateAction<Pod | undefined>>,
           jest.fn() as Dispatch<SetStateAction<string | undefined>>
         )
@@ -86,6 +87,7 @@ describe("Custom Pods hook", () => {
           "default",
           "simple-pipeline",
           "cat",
+          undefined,
           jest.fn() as Dispatch<SetStateAction<Pod | undefined>>,
           jest.fn() as Dispatch<SetStateAction<string | undefined>>
         )
@@ -106,6 +108,7 @@ describe("Custom Pods hook", () => {
           "default",
           "simple-pipeline",
           "cat",
+          undefined,
           jest.fn() as Dispatch<SetStateAction<Pod | undefined>>,
           jest.fn() as Dispatch<SetStateAction<string | undefined>>
         )

diff --git a/ui/src/utils/fetcherHooks/podsViewFetch.ts b/ui/src/utils/fetcherHooks/podsViewFetch.ts
@@ -10,6 +10,7 @@ export const usePodsViewFetch = (
   namespaceId: string | undefined,
   pipelineId: string | undefined,
   vertexId: string | undefined,
+  selectedPod: Pod | undefined,
   setSelectedPod: Dispatch<SetStateAction<Pod | undefined>>,
   setSelectedContainer: Dispatch<SetStateAction<string | undefined>>
 ) => {
@@ -107,8 +108,10 @@ export const usePodsViewFetch = (
 
   useEffect(() => {
     if (pods?.length) {
-      setSelectedPod(pods[0]);
-      setSelectedContainer(pods[0]?.containers[0]);
+      if (!(selectedPod && pods?.find((pod) => pod?.name === selectedPod?.name))) {
+        setSelectedPod(pods[0]);
+        setSelectedContainer(pods[0]?.containers[0]);
+      }
     } else {
       setSelectedPod(undefined);
       setSelectedContainer(undefined);