fix: disallow updating an existing isbsvc's persistence strategy #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
whynowy
reviewed
Nov 17, 2023
webhook/validator/isbsvc.go
Outdated
| return DeniedResponse("can not change ISB Service type from Redis to Jetstream") | ||
| } | ||
| // check the persistence of ISB Service is not changed | ||
| if !equality.Semantic.DeepEqual(v.oldISBService.Spec.Redis.Native.Persistence, v.newISBService.Spec.Redis.Native.Persistence) { |
There was a problem hiding this comment.
Need to check if native is nil.
There was a problem hiding this comment.
Thanks! I am adding a nil check before deepequal. Do we need to handle native changing from nil to non-nil and vice versa?
whynowy
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow updating an existing isbsvc's persistence strategy. This includes removing, adding and modifying.