Added name to service spec #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
whynowy
reviewed
Jun 15, 2022
| @@ -81,6 +81,14 @@ func (v Vertex) GetServiceObjs() []*corev1.Service { | |||
| } | |||
|
|
|||
| func (v Vertex) getServiceObj(name string, headless bool, port int) *corev1.Service { | |||
| var servicePortName string | |||
There was a problem hiding this comment.
Pass the port name as a parameter.
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
whynowy
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Added name to service spec Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com> * Added vertexHTTPSPortName Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
yhl25
pushed a commit
to yhl25/numaflow
that referenced
this pull request
Sep 1, 2022
* Added name to service spec Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com> * Added vertexHTTPSPortName Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com> Signed-off-by: Yashash H L <yashash_hl@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a document for metrics and there was an ask to figure out how to scrape the metrics using the prometheus operator. As part of the exercise I had created some k8s serviceMonitors to monitor services(based on labels) and scrape the corresponding metric. While doing so I figured that the serviceMonitor expected a
namefield on the service spec Port object. Added the same.This has been tested by running a sample pipeline in my local k3d cluster