fix: add timeout to the test #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vigith Maurice <vigith@gmail.com>
whynowy
approved these changes
Mar 17, 2023
|
@whynowy, i don't think this PR has fixed anything :) |
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
… unit-test-hanging
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
added 3 commits
March 27, 2023 13:31
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
jy4096
pushed a commit
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Vigith Maurice <vigith@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com> Co-authored-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: jyu6 <juanlu_yu@intuit.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
whynowy
pushed a commit
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Vigith Maurice <vigith@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com> Co-authored-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: jyu6 <juanlu_yu@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests are randomly hanging.
https://github.com/numaproj/numaflow/actions/runs/4449652753/jobs/7814422441?pr=617, the potential culprit seems to be
TestNewInterStepDataForward