Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allowedLateness to support late data ingestion #703

Merged
merged 10 commits into from
Apr 25, 2023
Merged

feat: allowedLateness to support late data ingestion #703

merged 10 commits into from
Apr 25, 2023

Conversation

vigith
Copy link
Member

@vigith vigith commented Apr 21, 2023 •
edited
Loading

fixes #697 #694

  • documentation
  • unit test

@vigith
feat: allowedLateness to support late data ingestion
1c79c42 
Signed-off-by: Vigith Maurice <vigith@gmail.com>
@vigith vigith linked an issue Apr 21, 2023 that may be closed by this pull request
Ability to configure different late data in the same pipeline #694
Closed
whynowy
whynowy approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jyu6 and others added 9 commits April 24, 2023 18:07
take allowedLatency into consideration for window assignment and upda…
86551e0 
…te log msg

Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update log level
33a9c80 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add unit test
ad0505a 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Merge remote-tracking branch 'origin' into allowedLateness
0668bb3 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@vigith
fix: delay the bug check
864f614 
Signed-off-by: Vigith Maurice <vigith@gmail.com>
fix logic and test
aa7d60b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
fix the unit test
4b9f601 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update test
f4f54de 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update log msg
0fc2cf4 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@jy4096 jy4096 marked this pull request as ready for review April 25, 2023 16:29
@jy4096 jy4096 merged commit f518d99 into main Apr 25, 2023
@jy4096 jy4096 deleted the allowedLateness branch April 25, 2023 20:06
whynowy pushed a commit that referenced this pull request Apr 26, 2023
@vigith @whynowy
feat: allowedLateness to support late data ingestion (#703)
652be8d 
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: jyu6 <juanlu_yu@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees

@jy4096 jy4096

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowedLateness in reduce vertex Ability to configure different late data in the same pipeline
3 participants
@vigith @whynowy @jy4096