Skip to content

Commit

Permalink
fix: registry test_case (#197)
Browse files Browse the repository at this point in the history
Test cases for `is_model_stale` had freeze time set to fixed date. 
Now, when redis is fetching data that is older than 10 days (cause ttl
is set to 10 days), it automatically deletes this key and hence we were
seeing ModelKeyNotFound error.

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
  • Loading branch information
s0nicboOm committed May 22, 2023
1 parent 6da0dae commit 3193159
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions tests/registry/test_redis_registry.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import unittest
from datetime import datetime, timedelta
from unittest.mock import Mock, patch

import fakeredis
Expand Down Expand Up @@ -128,15 +129,17 @@ def test_load_model_with_version(self):
self.assertEqual(data.extras["version"], version)

def test_check_if_model_stale_true(self):
with freeze_time("2023-05-08 12:30:00"):
delta = datetime.today() - timedelta(days=5)
with freeze_time(delta):
self.registry.save(skeys=self.skeys, dkeys=self.dkeys, artifact=self.pytorch_model)
data = self.registry.load(skeys=self.skeys, dkeys=self.dkeys)
self.assertTrue(self.registry.is_artifact_stale(data, 12))

def test_check_if_model_stale_false(self):
with freeze_time("2023-05-08 12:30:00"):
delta = datetime.today()
with freeze_time(delta):
self.registry.save(skeys=self.skeys, dkeys=self.dkeys, artifact=self.pytorch_model)
with freeze_time("2023-05-08 19:30:00"):
with freeze_time(delta + timedelta(hours=7)):
data = self.registry.load(skeys=self.skeys, dkeys=self.dkeys)
self.assertFalse(self.registry.is_artifact_stale(data, 8))

Expand Down

0 comments on commit 3193159

Please sign in to comment.