fix: registry test_case #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 96.62% 96.82% +0.19%
==========================================
Files 36 36
Lines 1541 1541
Branches 119 119
==========================================
+ Hits 1489 1492 +3
+ Misses 36 34 -2
+ Partials 16 15 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ab93
approved these changes
May 22, 2023
ab93
pushed a commit
that referenced
this pull request
Jun 2, 2023
Test cases for `is_model_stale` had freeze time set to fixed date. Now, when redis is fetching data that is older than 10 days (cause ttl is set to 10 days), it automatically deletes this key and hence we were seeing ModelKeyNotFound error. Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93
pushed a commit
that referenced
this pull request
Jun 2, 2023
Test cases for `is_model_stale` had freeze time set to fixed date. Now, when redis is fetching data that is older than 10 days (cause ttl is set to 10 days), it automatically deletes this key and hence we were seeing ModelKeyNotFound error. Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for
is_model_stalehad freeze time set to fixed date.Now, when redis is fetching data that is older than 10 days (cause ttl is set to 10 days), it automatically deletes this key and hence we were seeing ModelKeyNotFound error.