Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sklearn base import for scikit learn v1.2 #112

Merged
merged 2 commits into from Dec 21, 2022
Merged

fix: sklearn base import for scikit learn v1.2 #112

merged 2 commits into from Dec 21, 2022

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Dec 21, 2022

Fixing scikit-learn v1.2 onwards, removal of _OneToOneFeatureMixin.

@ab93 ab93 added the bug Something isn't working label Dec 21, 2022
@ab93 ab93 self-assigned this Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #112 (c61abc3) into main (64ad0ed) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   96.41%   96.10%   -0.31%     
==========================================
  Files          25       25              
  Lines         975      975              
  Branches       92       92              
==========================================
- Hits          940      937       -3     
- Misses         19       21       +2     
- Partials       16       17       +1     
Impacted Files Coverage Δ
numalogic/preprocess/transformer.py 96.29% <100.00%> (ø)
numalogic/synthetic/anomalies.py 96.84% <0.00%> (-3.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
@ab93 ab93 marked this pull request as ready for review December 21, 2022 22:58
@ab93 ab93 changed the title fix: fix sklearn base import for scikit learn v1.2 fix: sklearn base import for scikit learn v1.2 Dec 21, 2022
@ab93 ab93 merged commit df20591 into main Dec 21, 2022
@ab93 ab93 deleted the fix-sklearn branch December 21, 2022 23:00
ab93 added a commit that referenced this pull request Jan 5, 2023
* fix_readme: mention namespace name when applying the pipeline (#88)
* fix: allow only patch updates in torch version due to cuda build errors on mac (#90)
* chore: bump to v0.2.7 for new release (#91)
* docs: updated CHANGELOG.md (#93)
* fix: change example pipeline mlflow port (#96)
* chore: use separate docker image for mlflow server (#101)
* Use mlflow-skinny instead of mlflow
* Update example dockerfile to have multi-stage; one for udf and one for mlflow
* Update docs to use quay.io images, instead of requiring build
* docs: updated CHANGELOG.md (#107)
* fix: sklearn base import for scikit learn v1.2 (#112)
* docs: updated CHANGELOG.md (#113)
* docs: updated CHANGELOG.md (#114)

Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Co-authored-by: s0nicboOm <i.kushalbatra@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants