Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change example pipeline mlflow port #96

Merged
merged 5 commits into from Nov 24, 2022
Merged

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Nov 22, 2022

Signed-off-by: s0nicboOm i.kushalbatra@gmail.com
Change the MLFlow port to point to default namespace.

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review November 22, 2022 12:48
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #96 (fbfcd2f) into main (06f20d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          20       20           
  Lines         948      948           
  Branches       92       92           
=======================================
  Hits          912      912           
  Misses         19       19           
  Partials       17       17           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
pyproject.toml Outdated Show resolved Hide resolved
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as draft November 23, 2022 10:24
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review November 23, 2022 10:31
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm requested a review from ab93 November 24, 2022 05:29
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ab93 ab93 merged commit d2c6293 into numaproj:main Nov 24, 2022
ab93 pushed a commit that referenced this pull request Nov 30, 2022
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93 added a commit that referenced this pull request Jan 5, 2023
* fix_readme: mention namespace name when applying the pipeline (#88)
* fix: allow only patch updates in torch version due to cuda build errors on mac (#90)
* chore: bump to v0.2.7 for new release (#91)
* docs: updated CHANGELOG.md (#93)
* fix: change example pipeline mlflow port (#96)
* chore: use separate docker image for mlflow server (#101)
* Use mlflow-skinny instead of mlflow
* Update example dockerfile to have multi-stage; one for udf and one for mlflow
* Update docs to use quay.io images, instead of requiring build
* docs: updated CHANGELOG.md (#107)
* fix: sklearn base import for scikit learn v1.2 (#112)
* docs: updated CHANGELOG.md (#113)
* docs: updated CHANGELOG.md (#114)

Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Co-authored-by: s0nicboOm <i.kushalbatra@gmail.com>
Co-authored-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants