Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: unify and refactor trainer #315

Merged
merged 3 commits into from
Oct 30, 2023
Merged

chore!: unify and refactor trainer #315

merged 3 commits into from
Oct 30, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Oct 12, 2023

  • improve and unify Trainer with better logging and performance
  • add VAE model to model factory
  • rc0 version

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Oct 12, 2023
@ab93 ab93 added the area/ml Machine Learning based changes label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #315 (341d05d) into main (509e38a) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   93.93%   93.70%   -0.23%     
==========================================
  Files          77       76       -1     
  Lines        3495     3464      -31     
  Branches      280      278       -2     
==========================================
- Hits         3283     3246      -37     
- Misses        160      170      +10     
+ Partials       52       48       -4     
Files Coverage Δ
numalogic/blocks/_nn.py 100.00% <100.00%> (ø)
numalogic/config/_config.py 100.00% <100.00%> (ø)
numalogic/config/factory.py 87.83% <100.00%> (+0.16%) ⬆️
numalogic/models/autoencoder/__init__.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/base.py 97.87% <100.00%> (-0.44%) ⬇️
numalogic/models/autoencoder/variants/conv.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/variants/vanilla.py 100.00% <100.00%> (ø)
numalogic/models/vae/__init__.py 100.00% <100.00%> (ø)
numalogic/tools/trainer.py 95.65% <100.00%> (ø)
numalogic/udfs/postprocess.py 87.50% <100.00%> (+0.83%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review October 12, 2023 17:45
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm s0nicboOm merged commit 61f4575 into main Oct 30, 2023
10 checks passed
@s0nicboOm s0nicboOm deleted the vae-factory branch October 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ml Machine Learning based changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants