Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retrain logic for insufficient data #321

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Nov 6, 2023

Tackling retraining for insufficient data.

image image

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bbb53d) 93.70% compared to head (53f64f5) 93.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   93.70%   93.83%   +0.12%     
==========================================
  Files          76       76              
  Lines        3464     3486      +22     
  Branches      278      280       +2     
==========================================
+ Hits         3246     3271      +25     
+ Misses        170      168       -2     
+ Partials       48       47       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review November 13, 2023 20:22
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

numalogic/config/_config.py Outdated Show resolved Hide resolved
numalogic/udfs/tools.py Outdated Show resolved Hide resolved
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise LGTM

numalogic/config/_config.py Show resolved Hide resolved
numalogic/udfs/tools.py Outdated Show resolved Hide resolved
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm merged commit 46cdfcd into numaproj:main Nov 14, 2023
10 checks passed
@s0nicboOm s0nicboOm deleted the insufficient_data branch November 14, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants