Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RDS Trainer UDF changes #371

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

SaiSharathReddy
Copy link
Contributor

Adding RDS Trainer UDF Implementation which works based on MD5 Hash based approach.

Previous PR : #364

Signed-off-by: skondakindi <saisharathreddy_kondakindi@intuit.com>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 99.20000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.07%. Comparing base (e7e879c) to head (85d16b6).

Files Patch % Lines
numalogic/connectors/_config.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   92.93%   93.07%   +0.14%     
==========================================
  Files          95       97       +2     
  Lines        4385     4492     +107     
  Branches      379      387       +8     
==========================================
+ Hits         4075     4181     +106     
  Misses        231      231              
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

skondakindi and others added 2 commits May 7, 2024 10:44
Signed-off-by: skondakindi <saisharathreddy_kondakindi@intuit.com>
Signed-off-by: Saisharath Reddy Kondakindi <srsharathreddy@gmail.com>
@ab93 ab93 merged commit f29f771 into numaproj:main May 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants