Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add test cases for payload Transformer #397

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix: add test cases for payload Transformer #397

merged 3 commits into from
Jun 25, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jun 25, 2024 •
edited

  1. Make metrics disabled by default
  2. Fix transformer Payload bug.
  3. Add Test case for Payload Transformer vertex

@s0nicboOm
fix: add test cases for payload Transformer
1099904 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
@s0nicboOm
fix: increase coverage
9a3630c 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (7fa698c) to head (b33b04e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   92.30%   92.22%   -0.09%     
==========================================
  Files          97       97              
  Lines        4782     4782              
  Branches      430      430              
==========================================
- Hits         4414     4410       -4     
- Misses        270      275       +5     
+ Partials       98       97       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s0nicboOm s0nicboOm marked this pull request as ready for review June 25, 2024 18:54
@s0nicboOm
fix: patch version update
b33b04e 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
nkoppisetty
nkoppisetty approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for adding the test cases!

@s0nicboOm s0nicboOm merged commit 4b38829 into main Jun 25, 2024
13 checks passed
@s0nicboOm s0nicboOm deleted the metrics-fix branch June 25, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab93 ab93 ab93 approved these changes

@nkoppisetty nkoppisetty nkoppisetty approved these changes

@qhuai qhuai Awaiting requested review from qhuai qhuai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s0nicboOm @ab93 @nkoppisetty