Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IntelJIT events for LLVM for VTune support #394

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

anton-malakhov
Copy link
Contributor

As title. @sklam @seibert

@coveralls
Copy link

coveralls commented Sep 13, 2018

Coverage Status

Coverage remained the same at 93.768% when pulling 5d8d78c on anton-malakhov:develop into a70dc9e on numba:master.

@seibert seibert requested a review from sklam September 27, 2018 18:09
@stuartarchibald stuartarchibald mentioned this pull request Oct 4, 2018
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to test this with oprofile but I can't get llvm to build with oprofile enabled. However, we shouldn't let that be a blocker for this PR. This PR looks good to me.

@stuartarchibald
Copy link
Contributor

+1 for the proposed change, but please could the build number(s) in the conda build meta.yaml be incremented to reflect that this build is technically different to the previous. Once done I'll do a rebuild on the farm to check this works for all architectures. Thanks.

@codecov-io
Copy link

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          33       33           
  Lines        5159     5159           
  Branches      358      358           
=======================================
  Hits         4764     4764           
  Misses        320      320           
  Partials       75       75

@stuartarchibald
Copy link
Contributor

Thanks for the fix @anton-malakhov

@stuartarchibald
Copy link
Contributor

This built fine on all platforms for both llvmdev and llvmlite. Am running Numba smoke tests against these builds with numba/numba#3307

@stuartarchibald
Copy link
Contributor

Numba smoke tests were ok.

@stuartarchibald stuartarchibald added Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 19, 2018
@stuartarchibald
Copy link
Contributor

Thanks for the contribution. Merging.

@stuartarchibald stuartarchibald merged commit 48db094 into numba:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BuildFarm Passed For PRs that have been through the buildfarm and passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants