-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IntelJIT events for LLVM for VTune support #394
Conversation
ff1dec8
to
44c23e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test this with oprofile but I can't get llvm to build with oprofile enabled. However, we shouldn't let that be a blocker for this PR. This PR looks good to me.
+1 for the proposed change, but please could the build number(s) in the conda build |
e401663
to
5d8d78c
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 33 33
Lines 5159 5159
Branches 358 358
=======================================
Hits 4764 4764
Misses 320 320
Partials 75 75 |
Thanks for the fix @anton-malakhov |
This built fine on all platforms for both llvmdev and llvmlite. Am running Numba smoke tests against these builds with numba/numba#3307 |
Numba smoke tests were ok. |
Thanks for the contribution. Merging. |
As title. @sklam @seibert