Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NUMBA_ENABLE_PROFILING envvar, enabling jit event #3307

Merged
merged 3 commits into from Oct 19, 2018

Conversation

anton-malakhov
Copy link
Contributor

Default value depends on whether profiling was detected
It also serves as a default value for NUMBA_DEBUGINFO

@sklam @seibert

@anton-malakhov
Copy link
Contributor Author

On Azure, the build error is not related to this PR: 2018-09-13T19:36:47.6095703Z ./miniconda.sh: 373: ./miniconda.sh: /home/vsts/miniconda3/pkgs/python-3.7.0-hc3d631a_0/bin/python: not found

@seibert
Copy link
Contributor

seibert commented Sep 13, 2018

Yeah, this is a random failure that just started happening due to something strange (and apparently random) in the environment setup. It's almost like some of the build machines on Azure are behaving differently than others.

@anton-malakhov
Copy link
Contributor Author

Ok, I'll try to restart testing by force-pushing this commit

@seibert
Copy link
Contributor

seibert commented Sep 13, 2018

Don't worry too much about it for now. We're treating the Azure results as "informative" while we evaluate how stable the service is.

@anton-malakhov
Copy link
Contributor Author

@seibert could you please review the envvar name and changes to the defaults in this PR? I could sketch a doc section as well, if it works for you this way

@codecov-io
Copy link

codecov-io commented Sep 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@289254b). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #3307   +/-   ##
=========================================
  Coverage          ?   80.58%           
=========================================
  Files             ?      390           
  Lines             ?    78335           
  Branches          ?     8854           
=========================================
  Hits              ?    63126           
  Misses            ?    13811           
  Partials          ?     1398

@seibert
Copy link
Contributor

seibert commented Sep 27, 2018

This looks fine to me, but what code is calling lib_from_sym in helperlib?

@anton-malakhov
Copy link
Contributor Author

Oops.. looks like it is a branch collision - I forgot I have this PR open and created this function for solving certain issues with multiple openmp copies. I'll roll it back

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. On inspection this looks good. Will be interesting to see if perf can also be enabled in LLVM 7.

docs/source/reference/envvars.rst Outdated Show resolved Hide resolved
@sklam
Copy link
Member

sklam commented Oct 16, 2018

adding reference to numba/llvmlite#394

@stuartarchibald
Copy link
Contributor

Testing this PR needs merge of #3424, then to do a merge build with master so as to pick up llvmlite 0.26 (where the linked changes are proposed).

@stuartarchibald
Copy link
Contributor

Smoke test build passed, only failures were unrelated. Merging!

@stuartarchibald stuartarchibald merged commit 150c331 into numba:master Oct 19, 2018
@anton-malakhov
Copy link
Contributor Author

Thanks!

@stuartarchibald
Copy link
Contributor

No problem. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants