Merge pull request #3716 from ehsantn/unicode_iadd

Support inplace concat of strings

numba/tests/test_unicode.py

@@ -38,6 +38,9 @@ def getitem_usecase(x, i):
 def concat_usecase(x, y):
     return x + y
 
+def inplace_concat_usecase(x, y):
+    x += y
+    return x
 
 def in_usecase(x, y):
     return x in y
@@ -291,6 +294,15 @@ def test_concat(self, flags=no_pyobj_flags):
                                  cfunc(a, b),
                                  "'%s' + '%s'?" % (a, b))
 
+    def test_inplace_concat(self, flags=no_pyobj_flags):
+        pyfunc = inplace_concat_usecase
+        cfunc = njit(pyfunc)
+        for a in UNICODE_EXAMPLES:
+            for b in UNICODE_EXAMPLES[::-1]:
+                self.assertEqual(pyfunc(a, b),
+                                 cfunc(a, b),
+                                 "'%s' + '%s'?" % (a, b))
+
     def test_pointless_slice(self, flags=no_pyobj_flags):
         def pyfunc(a):
             return a[:]

numba/unicode.py

@@ -529,6 +529,7 @@ def getitem_slice(s, idx):
 
 
 @overload(operator.add)
+@overload(operator.iadd)
 def unicode_concat(a, b):
     if isinstance(a, types.UnicodeType) and isinstance(b, types.UnicodeType):
         def concat_impl(a, b):