Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inplace concat of strings #3716

Merged
merged 1 commit into from Jan 30, 2019
Merged

Support inplace concat of strings #3716

merged 1 commit into from Jan 30, 2019

Conversation

ehsantn
Copy link
Collaborator

@ehsantn ehsantn commented Jan 29, 2019

As title.

@stuartarchibald stuartarchibald added this to the Numba 0.43 RC milestone Jan 29, 2019
@stuartarchibald stuartarchibald added this to Need Review in Active Jan 29, 2019
@seibert
Copy link
Contributor

seibert commented Jan 29, 2019

Looks good to me. I didn't realize that iadd could wrap the same implementation as add.

@seibert seibert added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Jan 29, 2019
@sklam sklam moved this from Need Review to Ready to Merge in Active Jan 29, 2019
@sklam sklam merged commit e475b97 into numba:master Jan 30, 2019
Active automation moved this from Ready to Merge to Done Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
Active
Done
Milestone
Numba 0.43 RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehsantn @seibert @stuartarchibald @sklam