Move ROC vectorize init to npyufunc #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the registration and initialisation of ROC ufunc mech to the npyufunc init so that e.g. `@vectorize(target='roc')` works without having to `import numba.roc` before hand to ensure the ROC ufunc machinery is registered.
Codecov Report
@@ Coverage Diff @@
## master #3176 +/- ##
==========================================
- Coverage 81.13% 81.12% -0.01%
==========================================
Files 384 384
Lines 75077 75076 -1
Branches 8434 8434
==========================================
- Hits 60915 60907 -8
- Misses 12874 12882 +8
+ Partials 1288 1287 -1 |
stuartarchibald
added
Pending BuildFarm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the registration and initialisation of ROC ufunc mech
to the npyufunc init so that e.g.
@vectorize(target='roc')works without having to
import numba.rocbefore hand to ensurethe ROC ufunc machinery is registered.