-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ROC target documentation. #3178
Conversation
This updates the ROC target documentation to reflect the work on dGPUs and retires the work on APU. It: * Accommodates the HSA->ROC changes * Adds instructions on installation and setup * Updates examples and makes sure they work! * Adds new device function example * Adds section on ROC ufuncs, including async streaming gufuncs Minor code changes: * numba.roc.agents now works and lists the available agents
setup.py
Outdated
@@ -236,7 +236,7 @@ def rec(path, pkg_name): | |||
"numba.annotations": ["*.html"], | |||
# Various test data | |||
"numba.cuda.tests.cudadrv.data": ["*.ptx"], | |||
"numba.hsa.tests.hsadrv": ["*.brig"], | |||
"numba.roc.tests.hsadrv": ["*.brig"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we are still shipping any .brig files. There is one unit test, but it references a file under `/opt/rocm'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks, I don't think any brigs are shipped now.
Looks great! I had one minor nit about setup.py. |
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 81.13% 81.08% -0.06%
==========================================
Files 384 384
Lines 75077 75190 +113
Branches 8434 8441 +7
==========================================
+ Hits 60915 60965 +50
- Misses 12874 12933 +59
- Partials 1288 1292 +4 |
As title.
Thanks for the review, I've addressed #3178 (comment) in 95939f1. |
This updates the ROC target documentation to reflect the work on
dGPUs and retires the work on APU. It:
Minor code changes: