Update ROC target documentation. #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ROC target documentation to reflect the work on dGPUs and retires the work on APU. It: * Accommodates the HSA->ROC changes * Adds instructions on installation and setup * Updates examples and makes sure they work! * Adds new device function example * Adds section on ROC ufuncs, including async streaming gufuncs Minor code changes: * numba.roc.agents now works and lists the available agents
seibert
reviewed
Jul 31, 2018
setup.py
Outdated
| @@ -236,7 +236,7 @@ def rec(path, pkg_name): | |||
| "numba.annotations": ["*.html"], | |||
| # Various test data | |||
| "numba.cuda.tests.cudadrv.data": ["*.ptx"], | |||
| "numba.hsa.tests.hsadrv": ["*.brig"], | |||
| "numba.roc.tests.hsadrv": ["*.brig"], | |||
There was a problem hiding this comment.
I don't think we are still shipping any .brig files. There is one unit test, but it references a file under `/opt/rocm'.
There was a problem hiding this comment.
Ah yes, thanks, I don't think any brigs are shipped now.
|
Looks great! I had one minor nit about setup.py. |
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 81.13% 81.08% -0.06%
==========================================
Files 384 384
Lines 75077 75190 +113
Branches 8434 8441 +7
==========================================
+ Hits 60915 60965 +50
- Misses 12874 12933 +59
- Partials 1288 1292 +4 |
As title.
|
Thanks for the review, I've addressed #3178 (comment) in 95939f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ROC target documentation to reflect the work on
dGPUs and retires the work on APU. It:
Minor code changes: