-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dtype input argument in np.sum #4472
Merged
Merged
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9e5f6b7
added dtype kwarg (doesn't do anything) + tests
luk-f-a cf899bf
fixed impl - basic implementation passes tests
luk-f-a de3d1c0
format fixes and test removal
luk-f-a ee11c3d
added dtype-axis combination
luk-f-a 4d674fa
added dtype-axis tests
luk-f-a bbde75f
adjusting arraydecl (1 of 2)
luk-f-a 66d525c
adjusting arraydecl (2 of 2)
luk-f-a bd5014a
flake8 fixes
luk-f-a 7c3d9bb
factoring out common parts of sum implementations
luk-f-a 3abb4a8
added tests
luk-f-a 496eeca
fixed issue with np.int32 arrays
luk-f-a affa1ec
disabled timedelta test
luk-f-a b63d8d6
flake8 fix
luk-f-a 5a3e219
updated documentation
luk-f-a e0370f7
split out tests for int32 and uint32 due to special numpy behaviour
luk-f-a bebddf2
Merge branch 'master' into sum_with_dtype
luk-f-a 26ab11f
Merge branch 'master' into sum_with_dtype
luk-f-a d236a98
test fix for 32-bit machines
luk-f-a 0ffe381
fix for scalar results
luk-f-a 18be7fb
fixes to address review
luk-f-a 8959801
fix docs char limit
luk-f-a c25d0b5
changes after second review
luk-f-a 0726ed1
removing redundant tests
luk-f-a 50ac590
Word wrap docs
stuartarchibald f3a333b
Merge pull request #2 from stuartarchibald/pr_4472
luk-f-a 6bc30ed
removing redundant tests
luk-f-a 0d642a9
Merge remote-tracking branch 'origin/sum_with_dtype' into sum_with_dtype
luk-f-a 80feaa6
reverting addition of mean tests
luk-f-a a3074b4
reverting addition of mean tests2
luk-f-a File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section all needs line wrapping to 80 chars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, there's one left with 81 characters, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err no :) I can go fix it though so don't worry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, I didn't know it had to be strictly 80. I thought it was like a pep8 thing, where there's a bit of flexibility.