Restore numba.types as public API
#5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Testing moved modules in Q1 2020 but were decided to kept as public API | ||
| """ | ||
| def tests_numba_types(self): | ||
| import numba.types |
There was a problem hiding this comment.
Should e.g. from numba.types import containers be explicitly tested too?
There was a problem hiding this comment.
i can add a test. In general, I am only testing a few things because I am already checking for object identity. I don't think that's any reason for it to not work.
|
That error on macos is odd. |
|
This is unexpected: In [1]: import numba.types.misc
In [2]: numba.types.misc.StringLiteral
Out[2]: numba.types.misc.StringLiteral
In [3]: from numba.core import types
In [4]: types.StringLiteral
Out[4]: numba.core.types.misc.StringLiteral |
stuartarchibald
approved these changes
May 7, 2020
stuartarchibald
added
5 - Ready to merge
Closed
22 tasks
sklam
added a commit
that referenced
this pull request
May 7, 2020
and remove outdated test test_numba_types
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled.