-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore numba.types
as public API
#5676
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
"""Tests for moved modules and their redirection from old path | ||
""" | ||
from numba.tests.support import TestCase | ||
|
||
|
||
class TestMovedModule(TestCase): | ||
"""Testing moved modules in Q1 2020 but were decided to kept as public API | ||
""" | ||
def tests_numba_types(self): | ||
import numba.types | ||
import numba.core.types as types | ||
# The old module is the new module | ||
self.assertIs(numba.types, types) | ||
# Attribute access are there | ||
self.assertIs(numba.types.intp, types.intp) | ||
self.assertIs(numba.types.float64, types.float64) | ||
self.assertIs(numba.types.Array, types.Array) | ||
# Submodule access through old import path is possible | ||
import numba.types.misc | ||
self.assertIs(types.misc, numba.types.misc) | ||
self.assertIs(types.misc.Optional, numba.types.misc.Optional) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import sys | ||
import numba.core.types | ||
sys.modules[__name__] = numba.core.types |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should e.g.
from numba.types import containers
be explicitly tested too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can add a test. In general, I am only testing a few things because I am already checking for object identity. I don't think that's any reason for it to not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test added in 2998661