Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove deprecated tbb::task_scheduler_init, use new api #6096

Merged
merged 4 commits into from Mar 26, 2021

Conversation

Hardcode84
Copy link
Contributor

task_scheduler_init was removed in TBB_INTERFACE_VERSION == 12002 and new replacement api was added in 12003.

Also, 12002 lib is no longer binary compatible with previous versions so library name was changed (not properly handled yet).
Fork safety selection logic also wasn't updated.

@stuartarchibald
Copy link
Contributor

Thanks for opening this and starting work for the new TBB interfaces @Hardcode84

@Hardcode84
Copy link
Contributor Author

12002 binaries are available here: https://github.com/oneapi-src/oneTBB/releases/tag/v2021.1-beta08

@jschueller
Copy link

hello, I have trouble understanding what task_scheduler_handle does compared to task_scheduler_init,
as it has no methods outside of get/finalize, so I cant see where you can pass a number of threads etc.

@Hardcode84
Copy link
Contributor Author

Setting global thread count is still possible via global_control but discouraged (especially if you have other libraries which can use tbb internally, lke mkl ).

Set desired concurrency as task_arena ctor parameter

@henryiii
Copy link
Contributor

Guessing this limitation is still needed for Numba 0.53, leaving the pin in the conda-forge recipe for now.

@stuartarchibald
Copy link
Contributor

@Hardcode84 am hoping to get this in for the next (0.54) release, any chance you could please rebase this on current mainline? Thanks.

@Hardcode84
Copy link
Contributor Author

Rebased

@sklam sklam merged commit 2faea44 into numba:master Mar 26, 2021
@Hardcode84 Hardcode84 deleted the fix_tbb2_rebased branch March 27, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants