fix: cross2d wrong doc. reference (issue #6276)

[jeertmans]

See issue #6276 for more details

Closes #6276

[stuartarchibald]

Thanks for the patch. Think it'd be a good idea to update the unit tests too to make sure it's less likely to happen again. Suggest updating the import here to reflect the public API location:

numba/numba/tests/test_np_functions.py

Line 18 in db74d8f

from numba.np.arraymath import cross2d

and then checking the correct path is in the error string here:

numba/numba/tests/test_np_functions.py

Lines 3589 to 3592 in db74d8f

	self.assertIn(
	'Dimensions for both inputs is 2',
	str(raises.exception)
	)

Thanks!!

[stuartarchibald]

As the change log is a reflection of history I don't think that this should be changed, irrespective of this being in the wrong place for current Numba.

[jeertmans]

Ok my bad, I was doubtful about changing this but thank you for the information

[jeertmans]

Yes indeed, thank you for noticing @stuartarchibald . I did update the code.

I ran the test and it seems ok:

(numbaenv) jerome@jerome-N501VW:~/Documents/programmation/numba$ python -m numba.runtests numba.tests.test_np_functions.TestNPFunctions.test_cross_exceptions
>>> .
>>> ----------------------------------------------------------------------
>>> Ran 1 test in 2.907s
>>> 
>>> OK

[esc]

@jeertmans thanks for addressing the issue comments. From what I understand, @stuartarchibald suggested to add a check for the correct error string to the unit test. Something like:

 self.assertIn( 
     "a call to `cross2d(a, b)` from `numba.np.extensions`", 
     str(raises.exception) 
 ) 

To double check that the path listed in the error message is indeed the correct one.

[jeertmans]

Thanks for the explanation @esc ! I did commit an additional check for that purpose. I hope it follows your standards.

[esc]

@jeertmans excellent, thank you very much! I'll mark it as Ready to Merge under the assumption that @stuartarchibald will agree.

[stuartarchibald]

Thanks for the patch and fixes.

[stuartarchibald]

@jeertmans Congratulations on your first contribution to Numba!

[jeertmans]

Thank you both @stuartarchibald and @esc , I appreciate your help and I hope to be able to contribute more :)