Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cross2d wrong doc. reference (issue #6276) #6277

Merged
merged 7 commits into from
Sep 24, 2020
Merged

fix: cross2d wrong doc. reference (issue #6276) #6277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45a5e37
fix: cross2d wrong doc. reference (issue #6276)
jeertmans Sep 23, 2020
079ed5d
updating import accord. to API
jeertmans Sep 23, 2020
ad7a10a
Nicer cross to cross2d error text
jeertmans Sep 23, 2020
c4b3565
revert changes in CHANGE_LOG
jeertmans Sep 23, 2020
fa01070
Merge remote-tracking branch 'origin/master'
jeertmans Sep 23, 2020
d79d2c9
typo
jeertmans Sep 23, 2020
fe81fcc
check for correct message error
jeertmans Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion numba/np/arraymath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4395,7 +4395,7 @@ def impl(a, b):
raise ValueError((
"Dimensions for both inputs is 2.\n"
"Please replace your numpy.cross(a, b) call with "
"numba.numpy_extensions.cross2d(a, b)."
"a call to `cross2d(a, b)` from `numba.np.extensions`."
))
return impl

Expand Down
9 changes: 7 additions & 2 deletions numba/tests/test_np_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from numba.core.errors import TypingError
from numba.core.config import IS_WIN32, IS_32BITS
from numba.core.utils import pysignature
from numba.np.arraymath import cross2d
from numba.np.extensions import cross2d
from numba.tests.support import (TestCase, CompilationCache, MemoryLeakMixin,
needs_blas, skip_ppc64le_issue4026)
import unittest
Expand Down Expand Up @@ -3587,7 +3587,12 @@ def test_cross_exceptions(self):
np.array((3, 4))
)
self.assertIn(
'Dimensions for both inputs is 2',
'Dimensions for both inputs is 2.',
str(raises.exception)
)

self.assertIn(
'`cross2d(a, b)` from `numba.np.extensions`.',
str(raises.exception)
)

Expand Down