fixed llvmir usage in create_module method

[rawwar]

fixes #7022

using llvmir instead of ir in create_module method of BaseContext

[sklam]

Makes me wonder if that method is actually dead code. Why is it never exercised?

[rawwar]

I see this being used in -

numba/numba/roc/target.py

Line 134 in d4d09f3

wrapper_module = self.create_module("hsa.kernel.wrapper")

I tried searching for any test cases that make use of this and couldn't so far. @gmarkall can you please help me out?

[gmarkall]

Makes me wonder if that method is actually dead code. Why is it never exercised?

I believe it's dead, and all target contexts override it.

I also came across this when I turned on flake8 for base.py (in PR #7001).

I see this being used in - ...

This may have bitrotted as the ROCm target is unmaintained - see #6991

[rawwar]

Shall I remove this method from BaseContext?

[gmarkall]

I'd be inclined to make it raise NotImplementedError instead, because subclasses of BaseContext should implement it. (Perhaps BaseContext should be an ABC, but I don't think it's worth going to the trouble of making it one for this PR).

[rawwar]

Sure, i'll make it raise NotImplementedError

[esc]

Thanks for the patch @stuartarchibald @rawwar !