Allow converting NumPy datetimes to int #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @apmasell, I think that converting |
|
In [3]: td = np.timedelta64(1, 'Y')
In [4]: td
Out[4]: numpy.timedelta64(1,'Y')
In [5]: int(td)
Out[5]: 1We'll need to check what numpy is doing to be sure. |
sklam
reviewed
Jun 1, 2022
numba/tests/test_npdatetime.py
Outdated
Comment on lines
566
to
598
| with self.assertRaises((TypeError, TypingError)): | ||
| f(DT('2014')) |
There was a problem hiding this comment.
Can you add a test when TypingError is raised that the expected message is shown?
sklam
added
4 - Waiting on author
Add support for `int(numpy.datetime64)` and `int(numpy.timedelta64)`.
As titled. Co-authored-by: Siu Kwan Lam <1929845+sklam@users.noreply.github.com>
Ensure the type conversion errors includes the desired message
apmasell
added
3 - Ready for Review
and removed
4 - Waiting on author
sklam
approved these changes
Mar 9, 2023
sklam
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
int(numpy.datetime64)andint(numpy.timedelta64).