Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE. Testing. Wip/np122 debug1 #8030

Closed
wants to merge 7 commits into from
Closed

DO NOT MERGE. Testing. Wip/np122 debug1 #8030

wants to merge 7 commits into from

Conversation

stuartarchibald
Copy link
Contributor

@stuartarchibald stuartarchibald commented May 10, 2022 •
edited

This is running CI with NumPy 1.22 everywhere, attempting to find potential micro-architectural differences in results.

@stuartarchibald stuartarchibald added the abandoned PR is abandoned (no reason required) label May 10, 2022
@stuartarchibald stuartarchibald changed the title Wip/np122 debug1 DO NOT MERGE. Testing. Wip/np122 debug1 May 10, 2022
@stuartarchibald stuartarchibald mentioned this pull request May 10, 2022
Merged
@stuartarchibald
Copy link
Contributor Author

The py38_np120_typeguard job passed in 1020703, it ran on a skylake-avx512 and the test: numba.tests.test_array_exprs.TestArrayExpressions.test_explicit_output which failed previously in e28b127 passed. I think this indicates that setting the env var NPY_DISABLE_CPU_FEATURES="AVX512_SKX" "fixes" the numerical precision issues related to the use of SVML low accuracy functions.

@stuartarchibald
Copy link
Contributor Author

The py38_np120_typeguard job passed in 1020703, it ran on a skylake-avx512 and the test: numba.tests.test_array_exprs.TestArrayExpressions.test_explicit_output which failed previously in e28b127 passed. I think this indicates that setting the env var NPY_DISABLE_CPU_FEATURES="AVX512_SKX" "fixes" the numerical precision issues related to the use of SVML low accuracy functions.

Looks like this fixed it.

@stuartarchibald
Copy link
Contributor Author

Checks complete, #8027 contains the fixes. Closing.

@stuartarchibald stuartarchibald mentioned this pull request May 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam Awaiting requested review from sklam

@esc esc Awaiting requested review from esc

Assignees
No one assigned
Labels
abandoned PR is abandoned (no reason required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stuartarchibald