Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numba v0.55.2 #93

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pygments
  • arm_pyart

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2386623083, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@henryiii
Copy link
Contributor

Looks like test_workqueue_aborts_on_nested_parallelism is broken on linux_aarch64 with:

lib/python3.9/site-packages/numba/np/ufunc/workqueue.cpython-39-aarch64-linux-gnu.so: undefined symbol: pthread_atfork

@henryiii
Copy link
Contributor

numba/numba#8094 looks suspect. Similar to an issue in #83.

@henryiii
Copy link
Contributor

Need to update limits still.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [59]

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@henryiii
Copy link
Contributor

Are seven errors to be expected when using NumPy 1.22 on Linux? Guessing that's what caused the errors, but I can check.

@henryiii henryiii marked this pull request as draft May 26, 2022 21:02
@henryiii
Copy link
Contributor

Yes, using NumPy 1.23 breaks 7 unit tests

@gmarkall gmarkall mentioned this pull request May 30, 2022
21 tasks
@stuartarchibald
Copy link
Contributor

@henryiii thanks for opening this. Just from a quick look at the failing tests and guessing... looks like numerical regressions using NumPy 1.22 on chips with AVX512 that are SkyLake+. The output from numba -s in the build logs has this new item:

2022-05-26T14:24:26.8511260Z __NumPy Information__
2022-05-26T14:24:26.8511575Z NumPy Version                                 : 1.22.4
2022-05-26T14:24:26.8512453Z NumPy Supported SIMD features                 : ('MMX', 'SSE', 'SSE2', 'SSE3', 'SSSE3', 'SSE41', 'POPCNT', 'SSE42', 'AVX', 'F16C', 'FMA3', 'AVX2', 'AVX512F', 'AVX512CD', 'AVX512VL', 'AVX512BW', 'AVX512DQ', 'AVX512_SKX')
2022-05-26T14:24:26.8513588Z NumPy Supported SIMD dispatch                 : ('SSSE3', 'SSE41', 'POPCNT', 'SSE42', 'AVX', 'F16C', 'FMA3', 'AVX2', 'AVX512F', 'AVX512CD', 'AVX512_KNL', 'AVX512_KNM', 'AVX512_SKX', 'AVX512_CLX', 'AVX512_CNL', 'AVX512_ICL')
2022-05-26T14:24:26.8514403Z NumPy Supported SIMD baseline                 : ('SSE', 'SSE2', 'SSE3')
2022-05-26T14:24:26.8514793Z NumPy AVX512_SKX support detected             : True

it's the last line that shows this particular condition is detected: NumPy AVX512_SKX support detected : True

This diagnostic was added to Numba in 0.55.2 as part of the NumPy 1.22 support, it was discovered here numba/numba#8030 (comment) that this dispatch-to-lower-precision-ufunc-loops feature could be disabled and the following was added to Numba's test scripts to do this:

https://github.com/numba/numba/blob/290a693641b85c327ab79e2430d60fe82666aa38/buildscripts/incremental/test.sh#L29-L41

I'm hoping if this PR contains similar at test time the test suite will pass again.

@njriasan
Copy link

@henryiii Do you have any estimate on when you think this will be available?

@henryiii
Copy link
Contributor

I was traveling the last two days but am back and should have time to try the fix suggested above today.

recipe/meta.yaml Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor

henryiii commented Jun 16, 2022

Ahh, I'm failing test_no_accidental_warnings (and two more, but they might be related).

Edit: Okay, I think I see what to add here.

@henryiii henryiii marked this pull request as ready for review June 17, 2022 13:37
@henryiii henryiii merged commit fd0ffed into conda-forge:main Jun 17, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.55.2_h65ed83 branch June 17, 2022 13:51
@maxnoe
Copy link

maxnoe commented Jun 18, 2022

Thanks guys! The incompatibility and the conda env solver that chose to install numpy 1.22 with numba 0.53 caused as some pain...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants