Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import jitclass from numba.experimental in jitclass documentation #8522

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Import jitclass from numba.experimental in jitclass documentation #8522

merged 1 commit into from
Oct 20, 2022

Conversation

armgabrielyan
Copy link
Contributor

jitclass is still part of experimental support, so it should be imported from numba.experimental. Updating the documentation for jitclass to reflect it.

@armgabrielyan
Import jitclass from numba.experimental
c3507b9 
`jitclass` is still part of experimental support and can be imported from `numba.experimental`.
stuartarchibald
stuartarchibald approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these mistakes in the docs.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Oct 20, 2022
@stuartarchibald stuartarchibald added this to the Numba 0.57 RC milestone Oct 20, 2022
@stuartarchibald stuartarchibald self-assigned this Oct 20, 2022
@armgabrielyan
Copy link
Contributor Author

Thank you!

@sklam sklam merged commit 7bac154 into numba:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@sklam sklam Awaiting requested review from sklam

Assignees

@stuartarchibald stuartarchibald

Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.57 RC
Development

Successfully merging this pull request may close these issues.
3 participants
@armgabrielyan @stuartarchibald @sklam