New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add misc script to find missing towncrier news files #9101
Conversation
@sklam, could you list in the script the set of libraries it depends?
Am I missing any other lib? |
RE: #9101 (comment) I have added the list to the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can confirm it works.
Could you include as well an example of how to use it?
If you run the script on this branch, you will see: > python maint/towncrier_checker.py --token=insert_gh_token --beginning=0.58.0dev0 --repo=numba/numba
Removing 8982 as already in CHANGELOG
Removing 8932 as already in CHANGELOG
Removing 9004 as already in CHANGELOG
Removing 8929 as already in CHANGELOG
Removing 8964 as already in CHANGELOG
Removing 8958 as already in CHANGELOG
Removing 8895 as already in CHANGELOG
Removing 8976 as already in CHANGELOG
Removing 8896 as already in CHANGELOG
Removing 8998 as already in CHANGELOG
Removing 9005 as already in CHANGELOG
Removing 8978 as already in CHANGELOG
Removing 9006 as already in CHANGELOG
Removing 8996 as already in CHANGELOG
Removing 8902 as already in CHANGELOG
Removing 8909 as already in CHANGELOG
Removing 8947 as already in CHANGELOG
Removing 8965 as already in CHANGELOG
Removing 8907 as already in CHANGELOG
PRs that are missing towncrier notes and not skipped
7262 https://github.com/numba/numba/pull/7262
7543 https://github.com/numba/numba/pull/7543
8462 https://github.com/numba/numba/pull/8462
8885 https://github.com/numba/numba/pull/8885
8892 https://github.com/numba/numba/pull/8892
8906 https://github.com/numba/numba/pull/8906
8911 https://github.com/numba/numba/pull/8911
8916 https://github.com/numba/numba/pull/8916
8944 https://github.com/numba/numba/pull/8944
8974 https://github.com/numba/numba/pull/8974
8988 https://github.com/numba/numba/pull/8988
8995 https://github.com/numba/numba/pull/8995
9035 https://github.com/numba/numba/pull/9035 The Everything else under |
Thanks, Siu! Already approved the PR. |
The script finds missing towncrier files by scanning for merge commits that are not already in the CHANGE_LOG or not have the
skip_release_notes
label on github for the PR.