Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add towncrier news snippets for PRs that are missing them. #9100

Merged
merged 1 commit into from Aug 2, 2023

Conversation

stuartarchibald
Copy link
Contributor

This adds news snippets for PRs that are scheduled for Numba 0.58 but were merged prior to towncrier being enabled and a news snippet being a requirement.

Closes #9070

This adds news snippets for PRs that are scheduled for Numba 0.58
but were merged prior to towncrier being enabled and a news snippet
being a requirement.

Closes numba#9070
@stuartarchibald stuartarchibald added this to the Numba 0.58 RC milestone Jul 27, 2023
@stuartarchibald stuartarchibald marked this pull request as ready for review July 27, 2023 15:50
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rewritten a script to scan for missing notes (#9101). For all minor refactoring and doc update PRs, I have added the skip_release_notes label.
I also skipped #8854 as it is a numba-dpex specific change that most user do not care.

The below comments contain suggestion for ReST syntax fixes and that the 8736 file is not needed as it is merged in 0.57.

Bitwise operation ``ufunc`` support for the CUDA target.
========================================================

Support is added for some ``ufunc``s associated with bitwise operation on the
Copy link
Member

@sklam sklam Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReST syntax error

Suggested change
Support is added for some ``ufunc``s associated with bitwise operation on the
Support is added for some ``ufunc``\ s associated with bitwise operation on the

``@vectorize`` accommodates arguments implementing ``__array_ufunc__``.
=======================================================================

Universal functions (``ufunc``s) created with ``numba.vectorize`` will now
Copy link
Member

@sklam sklam Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error

Suggested change
Universal functions (``ufunc``s) created with ``numba.vectorize`` will now
Universal functions (``ufunc``\ s) created with ``numba.vectorize`` will now

@@ -0,0 +1,5 @@
Support is added for ``numpy.lib.stride_tricks.sliding_window_view``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of 0.57. The PR was incorrectly entered into the 0.58 milestone. This file should be removed.

@sklam sklam added 4 - Waiting on author Waiting for author to respond to review doc and removed 3 - Ready for Review labels Jul 27, 2023
@sklam sklam mentioned this pull request Jul 31, 2023
@sklam
Copy link
Member

sklam commented Jul 31, 2023

I've made a fixup PRs for my review comments at #9112

@sklam sklam added abandoned PR is abandoned (no reason required) and removed 4 - Waiting on author Waiting for author to respond to review labels Aug 1, 2023
@esc esc merged commit d10576f into numba:main Aug 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned PR is abandoned (no reason required) doc skip_release_notes Skip towncrier requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add towncrier snippets for merged PRs in 0.58.0dev0
3 participants