Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups for PR#9100 #9112

Merged
merged 2 commits into from Aug 2, 2023
Merged

Fixups for PR#9100 #9112

merged 2 commits into from Aug 2, 2023

Conversation

sklam
Copy link
Member

@sklam sklam commented Jul 31, 2023

Address review suggestions in #9100

stuartarchibald and others added 2 commits July 27, 2023 16:00
@stuartarchibald
Add towncrier news snippets for PRs that are missing them.
d10576f 
This adds news snippets for PRs that are scheduled for Numba 0.58
but were merged prior to towncrier being enabled and a news snippet
being a requirement.

Closes numba#9070
@sklam
Fixups
4396a6c 
- remove 8736 which is part of the previous release
- fix syntax in 8974 and 8995
@sklam sklam mentioned this pull request Jul 31, 2023
Merged
@sklam sklam added 3 - Ready for Review Effort - short Short size effort needed labels Aug 1, 2023
@sklam sklam added this to the Numba 0.58 RC milestone Aug 1, 2023
gmarkall
gmarkall approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - the docs for PRs #8974 and #8995 both render correctly, and the item for #8736 is removed.

@gmarkall gmarkall added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Aug 1, 2023
@esc esc merged commit d7a03e0 into numba:main Aug 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarkall gmarkall gmarkall approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.58 RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sklam @gmarkall @esc @stuartarchibald