allow casting optional type to numba concrete types
#9161
Conversation
|
I think this's a simple patch, tests are all passed. But how to fix the towncrier? @esc |
|
Hi, @sklam . Perhaps this PR can go into 0.58.0rc2 or 0.58.0? I think you can give this a quick review, only change one line source code and add a test for it. |
| elif isinstance(val, (types.Number, | ||
| types.Boolean, | ||
| types.IntEnumMember, | ||
| types.Optional)): |
There was a problem hiding this comment.
Does this permit something that is optional but not like a number?
There was a problem hiding this comment.
In current mainline, we have this, so I think we allow casting optional to any type in the lowering level?
Line 112 in d70830f
There was a problem hiding this comment.
This PR will let typeinfer also allow casting optional to any type (?) in the typing level, I think..
RC2 will be limited to regressions or critical security bugs. This patch will go towards 0.59. |
Added to the milestone for 0.59 |
dlee992
changed the title
optional type to types.int64optional type to numba concrete types
|
I made an alternative PR for this at #9248 |
You can see the added test case.
Without this patch, the test will fail. With this patch, we allow this kind of casting from optional to concrete_type, e.g.,
types.int64(optional_instance).