Fix automatic unwrapping of optional type #9248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklam
changed the title
sklam
changed the title
karthikkurella
approved these changes
Oct 19, 2023
guilhermeleobas
added
5 - Ready to merge
|
LGTM |
| return x | ||
|
|
||
| args = list(map(unpack_opt, args)) | ||
| sig = typer(*args, **kws) |
There was a problem hiding this comment.
Do the kwargs need unpacking too?
|
@karthikkurella @guilhermeleobas @sklam I am moving this back to the state: "Waiting on Author" as an additional comment has been raised by @stuartarchibald |
esc
added
4 - Waiting on author
|
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
guilhermeleobas
added
2 - In Progress
and removed
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #9161.
The root problem of optional typed arguments not unpacking is due to lack of exception handling around the
typer. With the fix, we don't need to specialize individual function to handle optional types.