New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy 2.0 binary support testing #9466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initions if possible
… wrongly accessed C-level dead code in multithreaded envionment
kc611
force-pushed
the
numpy_2_binary
branch
2 times, most recently
from
March 19, 2024 09:40
21154b9
to
3b204a9
Compare
gpuci run tests |
gpuci run tests |
gpuci run tests |
BFID: |
sklam
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at all changes up to this point. It's now pending thorough testing on the buildfarm.
sklam
added
Pending BuildFarm
For PRs that have been reviewed but pending a push through our buildfarm
and removed
3 - Ready for Review
labels
Mar 25, 2024
sklam
requested changes
Mar 25, 2024
sklam
approved these changes
Mar 28, 2024
sklam
added
5 - Ready to merge
Review and testing done, is ready to merge
and removed
Pending BuildFarm
For PRs that have been reviewed but pending a push through our buildfarm
labels
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to merge
Review and testing done, is ready to merge
NumPy 2.0
Related to NumPy 2.0 support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled,
This PR aims to test and develop Numba's binary compatiblity against Numpy 2.0. For backwards compatiblity, according to Numpy docs for ABI compatiblity : "When you build wheels for your package using a NumPy 2.x version at build time, those will work with NumPy 1.xx."