Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 binary support testing #9466

Merged
merged 47 commits into from Mar 28, 2024
Merged

Numpy 2.0 binary support testing #9466

merged 47 commits into from Mar 28, 2024

Conversation

kc611
Copy link
Collaborator

@kc611 kc611 commented Feb 26, 2024

As titled,
This PR aims to test and develop Numba's binary compatiblity against Numpy 2.0. For backwards compatiblity, according to Numpy docs for ABI compatiblity : "When you build wheels for your package using a NumPy 2.x version at build time, those will work with NumPy 1.xx."

@kc611 kc611 closed this Mar 1, 2024
@kc611 kc611 reopened this Mar 1, 2024
@kc611 kc611 marked this pull request as ready for review March 1, 2024 08:10
@kc611 kc611 marked this pull request as draft March 1, 2024 08:11
@kc611 kc611 requested a review from gmarkall as a code owner March 1, 2024 08:13
@kc611 kc611 closed this Mar 6, 2024
@kc611 kc611 reopened this Mar 6, 2024
@kc611 kc611 force-pushed the numpy_2_binary branch 2 times, most recently from 21154b9 to 3b204a9 Compare March 19, 2024 09:40
@gmarkall
Copy link
Member

gpuci run tests

@gmarkall
Copy link
Member

gpuci run tests

@gmarkall
Copy link
Member

gpuci run tests

@sklam
Copy link
Member

sklam commented Mar 20, 2024

BFID: numba_npnext_yaml_10

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at all changes up to this point. It's now pending thorough testing on the buildfarm.

@sklam sklam added Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm and removed 3 - Ready for Review labels Mar 25, 2024
numba/_typeof.cpp Outdated Show resolved Hide resolved
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Mar 28, 2024
@sklam sklam added this to the 0.60.0-rc1 milestone Mar 28, 2024
@sklam sklam merged commit 89218bb into numba:main Mar 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge NumPy 2.0 Related to NumPy 2.0 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants