(Do Merge) NumPy 2: Removed dead code conflicting with binary builds against NumPy 2 #9474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc611
changed the title
sklam
reviewed
Mar 4, 2024
Comment on lines
-548
to
-557
| } else if (PyUFunc_ReplaceLoopBySignature(ufunc, | ||
| (PyUFuncGenericFunction)loop_ptr, | ||
| arg_types_arr, &old_func) == 0) { | ||
| /* TODO: Consider freeing any memory held by the old loop (somehow) */ | ||
| for (idx = 0; idx < ufunc->ntypes; idx++) { | ||
| if (ufunc->functions[idx] == (PyUFuncGenericFunction)loop_ptr) { | ||
| ufunc->data[idx] = data_ptr; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I found a case that reaches this:
from numba import vectorize, types
@vectorize
def foo(x):
return x
foo.add(tuple([types.intp]))
foo.add(tuple([types.intp]))I think it is valid for Numba to reject the second .add.
|
This PR is to be continued at #9466 along wih all the related NumPy 2 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled