Remove resolve_argument_type() from typing context
#9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarkall
added
2 - In Progress
CUDA
|
gpuci run tests |
It was only used by the CUDA target, and contained CUDA-specific code in the core of Numba, which was a bit of a violation of the target abstraction. The CUDA target's `typeof_pyval()` implements the same logic anyway, so we can just reuse that in the CUDA target.
gmarkall
force-pushed
the
remove-resolve-argument-type
branch
from
4c259c3
to
5b8a8e9
Compare
|
gpuci run tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used by the CUDA target, and contained CUDA-specific code in the core of Numba, which was a bit of a violation of the target abstraction.
The CUDA target's
typeof_pyval()implements the same logic anyway, so we can just reuse that in the CUDA target.